Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): add alert to SystemInfoCard if u2e driver outdated #5638

Merged
merged 5 commits into from
May 12, 2020
Merged

refactor(app): add alert to SystemInfoCard if u2e driver outdated #5638

merged 5 commits into from
May 12, 2020

Conversation

mcous
Copy link
Contributor

@mcous mcous commented May 8, 2020 •
edited
Loading

overview

Blocked by #5637. This PR will be re-targeted to edge once it's merged PR is ready for review

This PR adds a warning to the SystemInfoCard if the U2E driver is out of date. Closes #5491. See ticket for acceptance criteria.

changelog

  • refactor(app): add alert to SystemInfoCard if u2e driver outdated

review requests

  • enableSystemInfo feature flag should be enabled

  • If Windows, plug in a U2E adapter with your driver out of date

  • If not Windows, dispatch a fake USB device added action

    {
    type: 'systemInfo:USB_DEVICE_ADDED',
    payload: {
        usbDevice: {
            locationId: 1,
            vendorId: 256,
            productId: 2560,
            deviceName: 'Realtek USB FE Family Controller',
            manufacturer: 'Realtek',
            serialNumber: 'Serial Number',
            deviceAddress: 5,
            windowsDriverVersion: '10.0.0.0',
        }
    }
}

  • System Information card in More > Network and System page should show warning

  • Warning should have button to Realtek's download page

risk assessment

Low. Additions are unit tested and behind a feature flag

@mcous mcous added app Affects the `app` project WIP robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020 •
edited
Loading

Codecov Report

Merging #5638 into edge will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #5638      +/-   ##
==========================================
- Coverage   65.02%   64.95%   -0.07%     
==========================================
  Files        1098     1101       +3     
  Lines       30687    30810     +123     
==========================================
+ Hits        19953    20012      +59     
- Misses      10734    10798      +64
Impacted Files Coverage Δ
app/src/analytics/index.js 9.09% <ø> (ø)
app/src/analytics/epics.js 100.00% <100.00%> (ø)
app/src/analytics/hooks.js 100.00% <100.00%> (ø)
...pp/src/components/Alerts/U2EDriverOutdatedAlert.js 100.00% <100.00%> (ø)
...pp/src/components/SystemInfoCard/U2EAdapterInfo.js 100.00% <100.00%> (ø)
.../src/components/SystemInfoCard/U2EDeviceDetails.js 100.00% <100.00%> (ø)
.../src/components/SystemInfoCard/U2EDriverWarning.js 100.00% <100.00%> (ø)
app/src/nav/selectors.js 100.00% <100.00%> (ø)
app/src/system-info/constants.js 100.00% <100.00%> (ø)
components/src/primitives/Link.js 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b318e...234da4d. Read the comment docs.

@mcous mcous mentioned this pull request May 8, 2020
Merged
@mcous mcous force-pushed the app_driver-warning-ui branch from e8fb7e2 to 1da668f Compare May 11, 2020 18:08
@mcous mcous changed the base branch from components_primitives to edge May 11, 2020 20:31
amitlissack
amitlissack approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@amitlissack amitlissack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcous mcous requested review from a team and IanLondon and removed request for a team May 11, 2020 22:43
@mcous mcous marked this pull request as ready for review May 11, 2020 22:43
@mcous mcous requested a review from a team as a code owner May 11, 2020 22:43
IanLondon
IanLondon approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dispatched the fake event w Redux DevTools and got the warning

code looks good as far as I can tell. Link is nice.

@mcous mcous merged commit 116f0c4 into edge May 12, 2020
@mcous mcous deleted the app_driver-warning-ui branch May 12, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanLondon IanLondon IanLondon approved these changes

@amitlissack amitlissack amitlissack approved these changes

Assignees
No one assigned
Labels
app Affects the `app` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add warning modal if Windows Realtek U2E driver is out of date
3 participants
@mcous @amitlissack @IanLondon